Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements with communication stability #64

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Improvements with communication stability #64

merged 1 commit into from
Oct 25, 2017

Conversation

josesimoes
Copy link
Member

Description

  • Correct implementation of slim semaphores in SendBufferAsync(), ReadBufferAsync() and PerformRequestAsync()
  • Remove ConfigureAwaitChecker Analyzer
  • Global remove ConfigureAwait(false) because context is required on 99% of the code
  • Correct code in SerialPort to use IsDevicesEnumerationComplete (regression)
  • Rework code on PerformRequestAsync()
  • Simplified several nested calls to remove the repeated await

Motivation and Context

How Has This Been Tested?

  • Tested with WPF test app

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Work on stability improvements
6247a7b 
- Correct implementation of slim semaphores in `SendBufferAsync()`, `ReadBufferAsync()` and `PerformRequestAsync()`
- Remove ConfigureAwaitChecker Analyzer
- Global remove ConfigureAwait(false) because context is required on 99% of the code
- Correct code in SerialPort to use IsDevicesEnumerationComplete (regression)
- Rework code on `PerformRequestAsync()`
- Simplified several nested calls to remove the _repeated_ await

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Oct 25, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Work on stability improvements Improvements with communication stability Oct 25, 2017
@josesimoes josesimoes merged commit 8424293 into nanoframework:develop Oct 25, 2017
@josesimoes josesimoes deleted the stability-improvements branch October 25, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot